Skip to content

REST API: Avoid infinite recursion when a post is its own parent #13924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorgefilipecosta wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

REST API: Avoid infinite recursion when a post is its own parent #13924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1797,17 +1797,17 @@ public function check_read_permission( $post ) {
return true;
}

// Can we read the parent if we're inheriting?
if ( 'inherit' === $post->post_status && $post->post_parent > 0 ) {
// Can we read the parent if we're inheriting? A post that is its own parent has none to check.
if ( 'inherit' === $post->post_status && $post->post_parent > 0 && $post->post_parent !== $post->ID ) {
$parent = get_post( $post->post_parent );
if ( $parent ) {
return $this->check_read_permission( $parent );
}
}

/*
* If there isn't a parent, but the status is set to inherit, assume
* it's published (as per get_post_status()).
* If there isn't a parent, or the post is its own parent, but the status is
* set to inherit, assume it's published (as per get_post_status()).
*/
if ( 'inherit' === $post->post_status ) {
return true;
Expand Down
24 changes: 24 additions & 0 deletions tests/phpunit/tests/rest-api/rest-attachments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,30 @@ public function test_get_item_inherit_status_with_invalid_parent() {
$this->assertSame( $attachment_id, $data['id'] );
}

public function test_get_item_inherit_status_with_self_parent() {
global $wpdb;

$attachment_id = self::factory()->attachment->create_object(
self::$test_file,
0,
array(
'post_mime_type' => 'image/jpeg',
'post_excerpt' => 'A sample caption',
)
);

// wp_insert_post() refuses to make a post its own parent, but imports and direct writes can.
$wpdb->update( $wpdb->posts, array( 'post_parent' => $attachment_id ), array( 'ID' => $attachment_id ) );
clean_post_cache( $attachment_id );

$request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/media/%d', $attachment_id ) );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();

$this->assertSame( 200, $response->get_status() );
$this->assertSame( $attachment_id, $data['id'] );
}

public function test_get_item_auto_status_with_invalid_parent_not_authenticated_returns_error() {
$attachment_id = self::factory()->attachment->create_object(
self::$test_file,
Expand Down
Loading