[#281] Add provider-agnostic deferred tool loading - #282
Draft
superdav42 wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #282 +/- ##
============================================
+ Coverage 86.60% 87.05% +0.44%
- Complexity 1335 1356 +21
============================================
Files 68 69 +1
Lines 4314 4402 +88
============================================
+ Hits 3736 3832 +96
+ Misses 578 570 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deferLoadingflag to function declarations while preserving eager-loading defaults and serialized compatibilityScope
This PR defines the provider-agnostic contract only. OpenAI and Anthropic request serialization, response parsing, and model metadata updates remain provider-repository follow-ups. Client-executed tool discovery is intentionally excluded.
Implementation notes
FunctionDeclarationcalls remain valid, anddeferLoading: falseis omitted from serialized output.PromptBuilder::usingToolSearch()explicitly requests native discovery.toolSearchmodel option, preventing silent eager fallback.ProviderDatarecords the originating provider ID with an opaque serializable payload; providers must validate ownership before replay.Verification
composer test:unit— 1,181 tests, 4,350 assertions passedcomposer lint— PHPCS and PHPStan passedResolves #281
aidevops.sh v3.32.290 plugin for OpenCode v1.18.23 with gpt-5.6-sol spent 2d 9h and 1,876,806 tokens on this with the user in an interactive session.