Skip to content

Icons: Add new asterisk icon - #85442

Merged
jasmussen merged 2 commits into
trunkfrom
add/asterisk-icon
Oct 23, 2026
Merged

jasmussen merged 2 commits into
trunkfrom
add/asterisk-icon

Conversation

@jasmussen

Copy link
Copy Markdown
Contributor

What?

Related to WordPress/wordpress-develop#14548 (review)

Adds a new asterisk icon that can be used for wildcard contexts, shaped like a bullet.

asterisk

Note we added an asterisk in the past, and removed it again because it wasn't used anywhere.

image

This new one has 6 arms instead of 8, per pending feedback in #81274 (comment).

Testing Instructions

npm run storybook:dev

Use of AI Tools

No, but the script in #85272 was used to normalise this icon, and it was coauthored with Opus 5.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: fushar <fushar@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 182bc31 trunk % Change
timeToFirstByte 41.9 ms +8.59% -4.18% 41.4 ms +9.18% -2.9% 1.21%
largestContentfulPaint 72 ms +5.56% -5.56% 72 ms +5.56% -5.56% 0%
lcpMinusTtfb 28.6 ms +18.88% -2.8% 30.05 ms +9.98% -7.49% -4.83%
wpBeforeTemplate 21.79 ms +15.88% -1.47% 21.96 ms +12.3% -1.78% -0.77%
wpTemplate 15.71 ms +8.27% -2.36% 16.15 ms +1.49% -4.27% -2.72%
wpTotal 38.79 ms +8.87% -4.31% 38.16 ms +10.06% -2.96% 1.65%
wpMemoryUsage 7.67 MB +0% -0% 7.64 MB +0% -0% 0.45%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric 182bc31 trunk % Change
timeToFirstByte 35.2 ms +6.39% -2.7% 34.65 ms +7.07% -1.3% 1.59%
largestContentfulPaint 80 ms +5% -5% 78 ms +2.56% -2.56% 2.56%
lcpMinusTtfb 43.95 ms +2.84% -4.1% 42.1 ms +5.58% -0.95% 4.39%
wpBeforeTemplate 19.52 ms +3.43% -1.54% 19.26 ms +5.4% -1.25% 1.35%
wpTemplate 12.59 ms +4.05% -1.43% 12.59 ms +2.46% -2.14% 0%
wpTotal 32.61 ms +6.87% -2.58% 31.96 ms +7.67% -1.28% 2.03%
wpMemoryUsage 6.36 MB +0% -0% 6.33 MB +0% -0% 0.55%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric 182bc31 trunk % Change
mediaProcessingJpeg 324.68 ms +0.44% -1.58% 321.16 ms +1.42% -0.94% 1.1%
mediaProcessingAvif 4789.07 ms +0.07% -0.32% 4801.53 ms +0.21% -0.15% -0.26%
mediaProcessingJpegToAvif 3346.03 ms +0.54% -0.03% 3375.3 ms +0.26% -0.34% -0.87%

media-upload

Metric 182bc31 trunk % Change
jpegUploadProcessing 1429.22 ms +0.62% -2.02% 1405.42 ms +0.47% -0.33% 1.69%
pngUploadProcessing 183.72 ms +2.63% -4.41% 177.28 ms +2.03% -2.27% 3.63%
largeJpegUploadProcessing 1396.81 ms +1% -0.65% 1402.2 ms +0.38% -0.66% -0.38%
multipleImageUploadProcessing 1473.46 ms +0.05% -0.54% 1495.01 ms +0.71% -2.07% -1.44%

post-editor

Metric 182bc31 trunk % Change
serverResponse 230.94 ms +14.35% -1.44% 253.08 ms +3.48% -6.66% -8.75%
firstPaint 249.9 ms +33.32% -41.91% 191.06 ms +50.14% -24.73% 30.8%
domContentLoaded 726.57 ms +2.41% -3.79% 708.85 ms +1.06% -2.19% 2.5%
loaded 727.61 ms +2.37% -3.83% 709.61 ms +1.05% -2.16% 2.54%
firstContentfulPaint 334.26 ms +3.37% -5.51% 322.32 ms +2.01% -1.68% 3.7%
firstBlock 2074.99 ms +5.59% -2.21% 1989.23 ms +1.98% -0.42% 4.31%
type 13.23 ms +3.17% -3.25% 12.83 ms +3.2% -4.29% 3.12%
typeWithoutInspector 12.63 ms +8.39% -1.74% 12.84 ms +4.52% -3.74% -1.64%
typeWithTopToolbar 15.62 ms +1.15% -2.5% 15.52 ms +1.8% -4.51% 0.64%
typeContainer 6.22 ms +4.66% -6.75% 6.12 ms +3.59% -1.63% 1.63%
focus 73.01 ms +9.83% -5.19% 66.9 ms +5.53% -2.78% 9.13%
firstFocus 136.17 ms +0% -0% 143.76 ms +0% -0% -5.28%
selectAll 327.05 ms +7.92% -2.25% 317.86 ms +0.19% -3.13% 2.89%
listViewOpen 44.77 ms +2.73% -9.2% 44.35 ms +6.43% -1.65% 0.95%
inserterOpen 25.77 ms +2.79% -6.6% 26.05 ms +3.84% -3.72% -1.07%
inserterHover 8.26 ms +9.56% -6.05% 8.15 ms +3.19% -4.17% 1.35%
inserterSearch 6.45 ms +3.57% -4.5% 6 ms +10.83% -3.83% 7.5%
loadPatterns 403.83 ms +2.94% -1.83% 404.08 ms +2.67% -1.89% -0.06%
wpTotal 224.52 ms +14.68% -1.49% 246.77 ms +3.53% -6.78% -9.02%
wpMemoryUsage 14.71 MB +0% -0% 14.67 MB +0% -0% 0.25%
wpDbQueries 55 +0% -0% 55 +0% -0% 0%

site-editor

Metric 182bc31 trunk % Change
serverResponse 500.38 ms +3.86% -4.66% 507.09 ms +3.57% -4.56% -1.32%
firstPaint 229 ms +19.1% -13.79% 275.01 ms +12.28% -3.62% -16.73%
domContentLoaded 1248.49 ms +1.44% -0.59% 1281 ms +3.38% -1.2% -2.54%
loaded 1249.58 ms +1.45% -0.59% 1282.34 ms +3.36% -1.21% -2.55%
firstContentfulPaint 459.29 ms +13.9% -9.6% 518.89 ms +4.19% -3.94% -11.49%
firstBlock 4655.29 ms +0.42% -0.18% 4763.43 ms +0.55% -0.79% -2.27%
type 18.81 ms +2.6% -5.53% 19.45 ms +3.34% -5.35% -3.29%
navigate 135.45 ms +7.74% -8.49% 128.49 ms +9.35% -4.21% 5.42%
loadPatterns 1282.42 ms +4.47% -2.33% 1274.91 ms +8.03% -1.21% 0.59%
loadPages 991.89 ms +2.74% -5.04% 995.22 ms +2.47% -6.29% -0.33%
wpTotal 491.35 ms +3.85% -4.75% 497.09 ms +3.84% -4.6% -1.15%
wpMemoryUsage 12.72 MB +0% -0% 12.69 MB +0% -0% 0.28%
wpDbQueries 44 +2.27% -0% 44 +2.27% -0% 0%

98c24a6 Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Regression: updating a specific option will only change its value and will not corrupt others in /test/e2e/specs/editor/various/core-settings.spec.js, passed after 1 failed attempt.
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
    "rewrite_rules",
-   "SERIALIZED DATA",
+   "",
  ]
    at forEach (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:46:26)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:43:35

98c24a6 Run

@fushar fushar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

@jasmussen

Copy link
Copy Markdown
Contributor Author

Noting that the PHP failures here appear unrelated to this PR, and they should be hitting all of trunk right now.

WordPress/wordpress-develop#14716 changed wp_get_registered_entity_field_modules() and wp_get_registered_entity_action_modules() to return a list of { id, fields } entries instead of a map keyed by module id, so that a numeric module id survives as a string. Gutenberg defines its own copies behind function_exists(), so core’s version now wins while our phpunit expectations still assert the old shape.

This probably needs a follow-up in lib/compat/wordpress-7.2/ and the entity fields/actions tests.

@oandregal

Copy link
Copy Markdown
Member

@jasmussen I've just merged #85390 that should fix them. I didn't expect Gutenberg's CI to pick the last WordPress version so fast! Should I know, I'd have synced the merging of both PRs. Sorry for the inconvenience.

jasmussen and others added 2 commits October 23, 2026 10:09
@jasmussen
jasmussen merged commit 2912997 into trunk Oct 23, 2026
78 checks passed
@jasmussen
jasmussen deleted the add/asterisk-icon branch October 23, 2026 09:28
@github-actions github-actions Bot added this to the Gutenberg 24.4 milestone Oct 23, 2026
@t-hamano t-hamano added the Backport to WP 7.2 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 24, 2026
@github-actions

Copy link
Copy Markdown

There was a conflict while trying to cherry-pick the commit to the wp/7.2 branch. Please resolve the conflict manually and create a PR to the wp/7.2 branch.

PRs to wp/7.2 are similar to PRs to trunk, but you should base your PR on the wp/7.2 branch instead of trunk.

# Checkout the wp/7.2 branch instead of trunk.
git checkout wp/7.2

# Create a new branch for your PR.
git checkout -b my-branch

# Cherry-pick the commit.
git cherry-pick 2912997c366cb607671f748f44fa410bddb97d97

# Check which files have conflicts.
git status

# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue

# Push the branch to the repository
git push origin my-branch

# Create a PR and set the base to the wp/7.2 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

t-hamano added a commit that referenced this pull request Oct 25, 2026
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: fushar <fushar@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport to WP 7.2 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants