Repository navigation
Icons: Add new asterisk icon - #85442
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the ⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. Regression: updating a specific option will only change its value and will not corrupt others in
|
|
Noting that the PHP failures here appear unrelated to this PR, and they should be hitting all of trunk right now. WordPress/wordpress-develop#14716 changed wp_get_registered_entity_field_modules() and wp_get_registered_entity_action_modules() to return a list of { id, fields } entries instead of a map keyed by module id, so that a numeric module id survives as a string. Gutenberg defines its own copies behind function_exists(), so core’s version now wins while our phpunit expectations still assert the old shape. This probably needs a follow-up in lib/compat/wordpress-7.2/ and the entity fields/actions tests. |
|
@jasmussen I've just merged #85390 that should fix them. I didn't expect Gutenberg's CI to pick the last WordPress version so fast! Should I know, I'd have synced the merging of both PRs. Sorry for the inconvenience. |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
138c5b9 to
98c24a6
Compare
|
There was a conflict while trying to cherry-pick the commit to the wp/7.2 branch. Please resolve the conflict manually and create a PR to the wp/7.2 branch. PRs to wp/7.2 are similar to PRs to trunk, but you should base your PR on the wp/7.2 branch instead of trunk. |
What?
Related to WordPress/wordpress-develop#14548 (review)
Adds a new asterisk icon that can be used for wildcard contexts, shaped like a bullet.
Note we added an asterisk in the past, and removed it again because it wasn't used anywhere.
This new one has 6 arms instead of 8, per pending feedback in #81274 (comment).
Testing Instructions
npm run storybook:dev
Use of AI Tools
No, but the script in #85272 was used to normalise this icon, and it was coauthored with Opus 5.