Programmatically build the storm.yaml file - #6
Open
eherot wants to merge 2 commits into
Open
Conversation
Conflicts: attributes/default.rb
…ton of options directly into the template Conflicts: attributes/default.rb attributes/nimbus.rb attributes/supervisor.rb attributes/zookeeper.rb recipes/default.rb templates/default/storm.yaml.erb
jeffbyrnes
force-pushed
the
evertrue/eherot/jsonize_yaml_config
branch
4 times, most recently
from
February 5, 2015 18:55
08a462e to
cf03338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than hard-coding a bunch of options in the template (and making it necessary to override the template to remove an option), just build the file directly from the attributes.
Note that I removed
local_mode_zmqbecause it wasn't actually in the template in the first place.I also made what should be an inconsequential change to how the nimbus_host's fqdn gets stored.
I apologize for lumping these two commits into one PR, it was mainly for my own sanity, and because this is actually a cherry-pick from our own heavily-developed fork, and I didn't want to land myself in merge-hell trying to re-do all of my work on the old attribute file layout.
Please let me know if you have any questions/comments/concerns and I will try to work through them!
/cc'ing my cow-orker @jeffbyrnes