Skip to content

Add Form Submission spec to prerendering.bs#426

Open
robertlin-chromium wants to merge 10 commits into
WICG:mainfrom
robertlin-chromium:introduce-form-submission-spec
Open

Add Form Submission spec to prerendering.bs#426
robertlin-chromium wants to merge 10 commits into
WICG:mainfrom
robertlin-chromium:introduce-form-submission-spec

Conversation

@robertlin-chromium
Copy link
Copy Markdown
Collaborator

No description provided.

@robertlin-chromium robertlin-chromium marked this pull request as draft February 20, 2026 13:21
Copy link
Copy Markdown
Collaborator

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domfarolino knows much more about specs than me, but spotted a couple of things that might need changing.

Comment thread prerendering.bs Outdated
Comment thread prerendering.bs Outdated
Comment thread prerendering.bs
@github-actions
Copy link
Copy Markdown

Preview:

@robertlin-chromium robertlin-chromium marked this pull request as ready for review February 25, 2026 02:58
Copy link
Copy Markdown
Collaborator

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread prerendering.bs Outdated
Comment thread prerendering.bs Outdated
Copy link
Copy Markdown
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR modify https://wicg.github.io/nav-speculation/prerendering.html#navigate-activation or elsewhere, in order to prevent existing form navigations from activating non-form_submission prerenders?

I ask this as a follow-up to #424 (comment). This PR doesn't really carry its weight if forms can always activate all prerenders 😅

Comment thread prerendering.bs
<p class="note">Implementations will still be allowed to treat prerender candidates as prefetches, per the modifications in [[#speculation-rules-processing]].</p>
</div>

<div algorithm="parse a speculation rule">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to modify step 2, and add form_submission to the list of keys that we "accept"?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just updated the activation matching algorithm. PTAL
As for the step 2, it seems a change is needed to another repo: https://github.com/whatwg/html/blob/main/source
I'm creating another PR addressing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants