ci: bump deprecated actions (VCST-5248) - #309
Merged
Merged
Conversation
maksimzinchuk
changed the title
npm rejects concurrent packument writes with a transient 409, which aborted the PR-preview publish midway through the package list. Retry each publish up to three times, and treat a version that is already on the registry as done so a re-run over a partially published set no longer fails with a 403.
|
📦 Preview published for commit Install the preview with dist-tag: npm install @vc-shell/framework@pr-309Or pin to the exact commit: npm install @vc-shell/framework@2.4.0-pr309.8ac73adPublished packages (dist-tag
|
maksimzinchuk
added a commit
that referenced
this pull request
Aug 19, 2026
## Problem `storybook-tests` downloads Chromium from Playwright's CDN on every run, and nothing caches it. That download is usually fast and sometimes not. Measured on the `Install Chromium` step across recent runs: | Run | Branch | Duration | | --- | --- | --- | | 32144859867 | fix/VCST-5671… | 19 s | | 32150224146 | main | 20 s | | 32150499441 | fix/VCST-5632… | 22 s | | 32226928338 | main | 73 s | | 32227333537 | main | 33 s | | 32227535262 | main | 241 s | | 32225221895 | VCST-5248 | **1379 s** | | 32227555174 | fix/VCST-5746… | **timed out at 25 min, still downloading** | The job's `timeout-minutes` is 25. When the download is slow, the step eats the entire budget and the story tests never run — the check reports failure having tested nothing. That is what happened on #310, whose own diff was two ai-agent files. Worth stating explicitly: this is **not** caused by #309 (`checkout@v4→v7`, `setup-node@v4→v7`). Those actions have nothing to do with browser downloads, and the fast/slow split straddles that merge — 33 s and 73 s runs landed on `main` after it. The variance is the CDN. ## Change Cache `~/.cache/ms-playwright`, keyed on the resolved playwright version rather than a hash of `yarn.lock`. The browser revision only changes when playwright does, so an unrelated dependency bump should not throw the cache away. System libraries live outside that directory, so they are installed either way: - cache miss → `playwright install --with-deps chromium`, as before - cache hit → `playwright install-deps chromium`, which is seconds The existing comment about needing the workspace binary rather than `yarn dlx` is preserved — that constraint still holds. ## Note on the first run The first run after this merges still pays the download once, to populate the cache. If it happens to land during a slow CDN window it can still hit the 25-minute timeout; a re-run will then find the cache warm. `timeout-minutes` is deliberately left at 25 — with the cache in place the step should be seconds, and raising the ceiling would just hide a future regression for longer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Test Plan
yarn checkpasses locallyyarn workspace @vc-shell/framework run testpassesBreaking Changes
Checklist
feat:,fix:,docs:,refactor:,chore:,test:,perf:,ci:,build:,style:, orrevert:)README.md/*.docs.md)yarn lint:check)Note
Low Risk
Changes are limited to workflow action pins and publish-script resilience; no application runtime or auth logic changes.
Overview
Updates CI/CD workflows to newer GitHub Actions versions (
actions/checkoutandactions/setup-nodeto v7,amannn/action-semantic-pull-requestto v6,actions/github-scriptto v9, and Docker build/login/push actions to v4/v7) acrossci, docs lint, PR title, publish, storybook, and sync-docs workflows.scripts/publish-packages.tsnow wrapsnpm publishwith up to 3 attempts and a 15s delay to handle transient registry 409 Conflict errors when multiple packages publish in sequence. After a failure it checks the registry withnpm viewand skips if that version is already published, so retries and partial runs do not fail on 403 duplicate publishes.Reviewed by Cursor Bugbot for commit 8ac73ad. Bugbot is set up for automated code reviews on this repo. Configure here.