Skip to content

feat(licenses): add workspace support - #1657

Merged
marcossevilla merged 15 commits into
mainfrom
feat/licenses-workspace
Aug 4, 2026
Merged

feat(licenses): add workspace support#1657
marcossevilla merged 15 commits into
mainfrom
feat/licenses-workspace

Conversation

@marcossevilla

@marcossevilla marcossevilla commented Jul 22, 2026

Copy link
Copy Markdown
Member

Status

IN DEVELOPMENT

Description

Closes #1273

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

marcossevilla and others added 7 commits July 22, 2026 17:54
@marcossevilla
feat(licenses): add workspace support
8a17916
@marcossevilla
Merge branch 'main' into feat/licenses-workspace
3347dab
@marcossevilla
fix: ci issues
cbfa5c0
@marcossevilla
Merge branch 'main' into feat/licenses-workspace
f889a12
@marcossevilla
Merge branch 'feat/licenses-workspace' of github.com:VeryGoodOpenSour…
dd9723f 
…ce/very_good_cli into feat/licenses-workspace
@marcossevilla
fix(licenses): exclude platform-divergent glob catch
b69346a
@marcossevilla @claude
fix(licenses): ignore platform-divergent catch clause for coverage
d54358d 
The FileSystemException catch in _expandMembers is only reachable on
Unix; on Windows glob swallows the ENOTDIR internally, leaving the catch
clause line uncovered. Wrap it in coverage:ignore-start/end so coverage
is 100% on both platforms.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@marcossevilla

marcossevilla commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

@vgvbot merge main into this PR and fix the conflicts that might show up

@unicoderbot

unicoderbot Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

On it, I'll merge the target branch into this PR and resolve any conflicts.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Fetching target branch
  • Merging target into PR
  • Updating PR branch

I merged main into this PR and resolved the conflicts.

unicoderbot Bot and others added 2 commits July 27, 2026 15:59
@unicoderbot @marcossevilla
Merge branch 'main' into feat/licenses-workspace
5e4ff63 
Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@marcossevilla
Merge branch 'main' into feat/licenses-workspace
aa7fe81
@marcossevilla

marcossevilla commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

hey @brianegan @samitsv

we will be moving forward with this PR to address the support for workspaces in the licenses command, please test your projects against this branch to see if it solves the issues you were experimenting, let me know how it goes, thanks!

@marcossevilla

marcossevilla commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@vgvbot merge main into this branch and address the conflicts

@unicoderbot

unicoderbot Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

On it, I'll merge the target branch into this PR and resolve any conflicts.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Fetching target branch
  • Merging target into PR
  • Updating PR branch

I merged main into this PR and resolved the conflicts.

@unicoderbot @marcossevilla
Merge branch 'main' into feat/licenses-workspace
7635e7a 
Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
HudsonJunior
HudsonJunior reviewed Jul 31, 2026
View reviewed changes
Comment thread lib/src/pubspec_workspace/pubspec_workspace.dart Outdated
HudsonJunior
HudsonJunior reviewed Jul 31, 2026
View reviewed changes
Comment thread lib/src/pubspec_workspace/pubspec_workspace.dart
@marcossevilla

marcossevilla commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@vgvbot /address-review

@unicoderbot

unicoderbot Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

On it, I'll address the review comments and push the changes.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Reviewing feedback
  • Working on changes
  • Pushing updates

I've pushed changes to address the feedback.

@marcossevilla
marcossevilla marked this pull request as ready for review August 3, 2026 10:34
@marcossevilla
marcossevilla requested a review from a team as a code owner August 3, 2026 10:34
@marcossevilla marcossevilla mentioned this pull request Aug 3, 2026
Closed
4 tasks
marcossevilla
marcossevilla commented Aug 3, 2026
View reviewed changes
Comment thread test/src/pubspec/pubspec_test.dart Outdated
@unicoderbot @marcossevilla
fix: address review feedback on PR #1657
32f2eca 
Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@unicoderbot

unicoderbot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Heads up — I'm auto-updating this PR by merging the latest main into this branch. No action needed; I'll comment again only if this update hits a conflict or an unexpected error.

@unicoderbot

unicoderbot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Heads up — I'm auto-updating this PR by merging the latest main into this branch. No action needed; I'll comment again only if this update hits a conflict or an unexpected error.

@marcossevilla
marcossevilla merged commit 7c3a176 into main Aug 4, 2026
24 checks passed
@marcossevilla
marcossevilla deleted the feat/licenses-workspace branch August 4, 2026 11:41
@vgvbot vgvbot mentioned this pull request Aug 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryzizub ryzizub ryzizub approved these changes
+1 more reviewer
@HudsonJunior HudsonJunior HudsonJunior approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Support packages check licenses with workspaces

3 participants

@marcossevilla @ryzizub @HudsonJunior