Repository navigation
Stamp DEB versions with the platform suite convention - #74
Merged
Merged
Conversation
The v1.2.0 tag build passed all six integration-lab lanes and then failed at the very last step: ciReleaseManifest reads DEB versions from the artifact filenames and accepts only <tag> or <tag>+<suite><n>, but our CPackProjectConfig hardcoded a nonconforming <version>.ubuntu2404 file name. Adopt the family-archive convention from the ci-cd-platform docs: version the DEB as <version>+<suite><release> (1.2.0+noble1) via a new OPENCATTUS_DEB_SUITE cache variable, drop the custom file-name override so DEB-DEFAULT emits opencattus_1.2.0+noble1_amd64.deb, and leave CPACK_DEBIAN_PACKAGE_RELEASE unset so CPack does not append a second release suffix after the stamp. Suites share one pool in the family archive, so the stamp also provides the required per-suite version uniqueness.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag build 5 passed all six integration-lab lanes and failed at the final manifest step:
ciReleaseManifest DEB version 1.2.0.ubuntu2404 ... does not match release tag v1.2.0. The manifest reads DEB versions from artifact filenames and accepts<tag>or<tag>+<suite><n>; ourCPackProjectConfig.cmake.inhardcoded a nonconforming<version>.ubuntu2404name.This adopts the documented family-archive convention (
<version>+<suite><release>, e.g.1.2.0+noble1) via anOPENCATTUS_DEB_SUITEcache var, removes the custom file-name override (DEB-DEFAULT then emitsopencattus_1.2.0+noble1_amd64.deb), and leavesCPACK_DEBIAN_PACKAGE_RELEASEunset so CPack doesn't append a second-1after the stamp (which would defeat the manifest's suffix strip). Suites share one pool archive-wide, so the stamp also provides the per-suite uniqueness the platform requires.