Fix: (typo) desctiption -> description in base_ga4__pseudonymous_users.yml - #397
Merged
mtcarlone merged 4 commits intoSep 8, 2026
Merged
Conversation
…s.yml The `desctiption` key on the `last_updated_date` column is unrecognized by dbt, so the intended description is silently dropped (the column ends up undocumented) and dbt 1.10+ raises a CustomKeyInObjectDeprecation warning on every parse for downstream projects that install this package. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
|
Thank you for submitting this. Github seems to be having a moment. I can't review the PR but I can request that I review the PR. Maybe @mtcarlone will have more luck. I'm not in the Velir organization but he is. |
Contributor
Author
|
Thanks @dgitis — really appreciate the quick look and the hand-off to @mtcarlone! No rush on my end. Happy to tweak anything if needed once GitHub settles down. 🙏 |
dgitis
self-requested a review
June 12, 2026 20:37
1 of 2 tasks
Collaborator
|
This will go out September 8, end of day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Fixes a typo in
models/staging/base/base_ga4__pseudonymous_users.yml: thelast_updated_datecolumn usesdesctiption:instead ofdescription:.This isn't purely cosmetic — because
desctiptionis an unrecognized key:last_updated_dateends up undocumented in the generated catalog/docs.CustomKeyInObjectDeprecationwarning on every parse, which surfaces in every downstream project that installs this package.Same class of fix as #385 (
Clint→Client).Checklist
descriptiondbt testandpython -m pytest .to validate existing tests — N/A, single YAML key rename with no SQL/logic change