Skip to content

fix: Remove underscore from check for Ensembl Protein ID #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bencap merged 2 commits into from
Jul 9, 2026
Merged

fix: Remove underscore from check for Ensembl Protein ID #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
138dad4
Merge pull request #105 from VariantEffect/mavedb-dev
bencap Jun 10, 2026
b317fd3
fix: Remove underscore from check for Ensembl Protein ID
davereinhart Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dcd_mapping/transcripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ async def select_transcripts(
target_gene
].target_accession_id
# TODO create full list of possible protein accession prefixes
if accession_id.startswith(("NP_", "ENSP_")):
if accession_id.startswith(("NP_", "ENSP")):
# TODO make sequence field optional instead of leaving blank here?
selected_transcripts[target_gene] = TxSelectResult(
np=accession_id,
Expand Down
Loading