Refactor development container configuration and local development environment - #5048
Refactor development container configuration and local development environment#5048clark-lawson wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Please get rid of the comments there - they are very redundant
There was a problem hiding this comment.
Not sure what to think about this - sure ps1 is good for windows but I'd rather go for something platform-agnostic like bash (with git bash on windows)
| echo "No database tables found. Recreating the database and seeding default data." | ||
|
|
||
| php artisan cts:migrate:fresh | ||
| php artisan migrate |
There was a problem hiding this comment.
Migrations can be safely re-ran and have to be ran every time a new one is added which the condition here does not know. CTS should probably be ran only once
There was a problem hiding this comment.
It may be worth checking https://github.com/devcontainers/features/tree/main/src/git
It works pretty well and we use it in our devcontainer setup for ukcp https://github.com/VATSIM-UK/uk-controller-api/blob/main/.devcontainer/devcontainer.json
There was a problem hiding this comment.
Remove redundant comments pls
There was a problem hiding this comment.
Can we possibly leave this present for backwards compatibility at least for now? Can be moved to another file if you wanna use it but I'd defo keep it
kristiankunc
left a comment
kristiankunc
left a comment
There was a problem hiding this comment.
Hey, overall I like the idea but there seems to be an insane amount of helper scripts which I feel are not really needed. I'd suggest taking a look at the ukcp-api repo which has a working devcontainer setup and works quite nicely - https://github.com/VATSIM-UK/uk-controller-api
3 participants
Summary
This PR reworks the project's development container configuration to provide a more consistent and maintainable local development experience.
The goal is to simplify onboarding, improve developer productivity, and make the development environment more reliable across machines and environments.
Changes
Benefits
Testing
Notes
This change only affects the development environment and does not modify application runtime behaviour or production deployments.