Adding possibility present prompt with custom UI + exposed ratingConditionsHaveBeenMet() func to public interface - #27
Open
ibru wants to merge 3 commits into
Open
Adding possibility present prompt with custom UI + exposed ratingConditionsHaveBeenMet() func to public interface#27ibru wants to merge 3 commits into
ibru wants to merge 3 commits into
Conversation
ratingConditionsHaveBeenMet func to public interface
Member
|
I can't add this without OS X, but I don't really have time to look into it at the moment. You may find it is not too hard to add it to the OS X code as the language is the same and API's are similar. Consult the example project. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've introduced new property
ratingPromptand a protocolArmchairRatingPromptwhich defines how rating prompt is shown. And provided 2 default implementation forUIlAlertViewandUIAlertController.Default implementation works exactly same as before (tested on Example app). You can specify your own prompt UI like this:
I'm not familiar with OS X development so I made the code iOS only. Didn't want to mess up OS X code.
I can also update iOS Example app to include example of using custom rating UI, if you want.
I also needed to know if rating conditions have been met, so I introduced new static func which exposes private
ratingConditionsHaveBeenMet()to public.