Updating ld-eventsource and yggdrasil-engine dependencies which require minimal Ruby version 3.1

[rgisiger]

About the changes

I updated ld-eventsource which was pinned to a fixed version. This change brings a minimal required version of Ruby 3.1.

I took the chance to update as well yggdrasil-engine to the latest version which was released recently.

All tests were green for rspec and rubocop.

Discussion points

I suggest to bump version of Unleash to version 7 since it brings a breaking change for the Ruby version.

[gee-forr]

@rgisiger - thanks for this!!! I was wondering if you could specify ~> 2.5 for ld-eventsource instead of ~> 2.5.1.

Reason for this is that 2.5.1 requires http at >= 4.4.1, < 6.0.0, whereas 2.6.0 which was recently released has changed its http version req to >= 4.4.1, < 7.0.0.

We're currently blocked from upgrading http from 5.x to 6 because of unleash's transitive dep on ld-eventsource. Your changes as they stand now will still prevent an upgrade of http.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[rgisiger]

Sorry for having taken so long to reply to your comment @gee-forr, I was a bit confused. Did you want to ask for ~> 2.6 version instead of 2.5.1 ?

Could we reopen the PR in the meantime or should I create a new one ?

[gee-forr]

Sorry for having taken so long to reply to your comment @gee-forr, I was a bit confused. Did you want to ask for ~> 2.6 version instead of 2.5.1 ?

Could we reopen the PR in the meantime or should I create a new one ?

Hi @rgisiger - no problems :)

You can specify ~> 2.5, but please do not specify ~> 2.5.1.

Using ~> 2.5 will resolve to 2.5.x all the way to 2.999.x which will naturally include 2.6.

I hope that's clearer? These versioning restrictions can get a bit tricky sometimes :)

[rgisiger]

You can specify ~> 2.5, but please do not specify ~> 2.5.1.

Using ~> 2.5 will resolve to 2.5.x all the way to 2.999.x which will naturally include 2.6.

I hope that's clearer? These versioning restrictions can get a bit tricky sometimes :)

Yes of course, I see what you mean, thank you. I have updated my changes.

[rgisiger]

@FredrikOseberg @thomasheartman

Could we reopen the PR in the meantime or should I create a new one ?

[sighphyre]

Gosh I have no idea why I didn't get notified about this one, so sorry this took so long and thanks for doing this

There are a few things I'd like to do before we release another major here, is this urgent for you @rgisiger?

[rgisiger]

Gosh I have no idea why I didn't get notified about this one, so sorry this took so long and thanks for doing this

There are a few things I'd like to do before we release another major here, is this urgent for you @rgisiger?

No problem, this is not urgent for me. I have also seen that the Rubocop job has failed.
Do you want me to adapt the Ruby version in the .github/workflows/pull_request.yml file as well (+ Readme for Ruby interpreters) ?

[sighphyre]

Gosh I have no idea why I didn't get notified about this one, so sorry this took so long and thanks for doing this
There are a few things I'd like to do before we release another major here, is this urgent for you @rgisiger?

No problem, this is not urgent for me. I have also seen that the Rubocop job has failed. Do you want me to adapt the Ruby version in the .github/workflows/pull_request.yml file as well (+ Readme for Ruby interpreters) ?

Nah don't stress, I'll tackle that in another PR. Dropping language version support is a major event for us so it needs a bit of internal chatter in the engineering department before we commit to that. Might mean this PR sits for a little longer but I'm definitely merging it soon(ish)!