Remove ignored hookData arg from initializePool call (#64)#94
Open
impetus82 wants to merge 1 commit into
Open
Conversation
) IPoolInitializer_v4.initializePool takes (PoolKey, uint160). The deploy script passed a third `hookData` argument that is silently ABI-appended and ignored, contradicting the interface and misleading developers who set a non-empty hookData expecting it to reach the pool. Drop the trailing argument. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #64.
IPoolInitializer_v4.initializePool(PoolKey, uint160)takes two arguments, butscript/01_CreatePoolAndAddLiquidity.s.solencoded theinitializePoolcall with a thirdhookDataargument. Becauseabi.encodeWithSelectoris variadic, the extrahookData(alwaysnew bytes(0)here) was silently appended to the calldata and ignored by the two-argument function — dead, misleading code that contradicts the interface and would confuse anyone setting a non-emptyhookDataexpecting it to reach the pool.Drop the trailing
hookDataargument so the encoded call matches the interface.hookDatais still used correctly for the liquidity mint below.(Note: the issue links the pre-rename path
01_CreatePoolAndMintLiquidity.s.sol; the file is now01_CreatePoolAndAddLiquidity.s.sol.)Closes #64
🤖 Generated with Claude Code