Repository navigation
feat: 어드민 대여 내역 장기 미반납 필터 - #520
Merged
Merged
Conversation
overdue=true면 대여 후 14일이 지났는데 반납하지 않은 대여 내역만 조회한다. 반납 기한을 History.RETURN_DEADLINE_DAYS 상수로 정리하고, 반납 기한만 다르던 RentService.toSingleHistoryResponse를 History.ofUserHistory로 합쳤다. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #512
🟢 구현내용
GET /admin/rent/histories에overdue쿼리 파라미터 추가.true면 대여 후 14일이 지났는데 반납하지 않은 대여 내역만 조회한다returned_at IS NULL AND rented_at <= 지금 - 14일countOfAllHistories)에 같이 적용. 기존refunded필터와 함께 쓸 수 있다false면 필터 없음 (기존 동작 그대로)History.RETURN_DEADLINE_DAYS(14일) 상수로 정리refunded,overdue,page,size) 문서 추가docs/feature/512.md🧩 고민과 해결과정
반납 기한이 두 군데 있었음
RentService.toSingleHistoryResponseHistory.ofUserHistory두 함수가 반납 기한 말고는 같아서, 상수를 만들고
History.ofUserHistory하나만 남겼습니다. 앱에 나가는 반납 예정일은 그대로 14일입니다. 이후 스탬프의 '정상 반납 완료' 미션(#514)도 이 상수를 쓰면 됩니다.테스트
RentRepositoryImplTest추가 (@DataJpaTest, H2): 반납 기한 지남+미반납 / 기한 안+미반납 / 기한 지남+반납 세 건 중 첫 번째만 조회되는지, 개수도 같은지 확인HistoryTest: 반납 예정일 기대값 7일 → 상수참고
HistoryTest.kt같은 줄을 고쳐서, 먼저 머지되는 쪽에 맞춰 다른 쪽을 리베이스해야 합니다.codex/필터링-기능에-지점과-입금-여부-추가브랜치가HistoryFilterRequest,RentRepositoryImpl에 지점·입금 필터를 추가해 둔 상태라, 그 브랜치를 살린다면 충돌을 정리해야 합니다.🤖 Generated with Claude Code