SAA-66: Add child-partner-nationality typeahead page

[jackbussHO]

What?

Add the /child-partner-nationality page

Why?

So that users can change nationality of child or partner

How?

Added to HOF config files

Testing?

Tested locally.

Screenshots (optional)

Anything Else? (optional)

Check list

• I have reviewed my own pull request for linting issues (e.g. adding new lines)
• I have written tests (if relevant)
• I have created a JIRA number for my branch
• I have created a JIRA number for my commit
• I have followed the chris beams method for my commit https://cbea.ms/git-commit/
  here is an example commit
• Ensure drone builds are green especially tests
• I will squash the commits before merging

[Copilot]

🟢 Approval recommended

The page is consistently wired through the journey, validation, translations, summary, and progressively enhanced typeahead.

0 open findings

What changed in this PR

Adds the child/partner nationality page with an accessible country typeahead and integrates it into the dependant journey.

Changes:

• Added country selection, validation, translations, and navigation.
• Added accessible autocomplete initialization and styling support.
• Included nationality in dependant summary data.

File	Description
assets/​scss/​app.scss	Prevents autocomplete results from receiving bullet styling.
assets/​js/​index.js	Initializes and synchronizes typeahead fields.
apps/​saa/​translations/​src/​en/​validation.json	Adds required-field validation text.
apps/​saa/​translations/​src/​en/​pages.json	Adds the page caption and heading.
apps/​saa/​translations/​src/​en/​fields.json	Adds the field label and placeholder option.
apps/​saa/​sections/​summary-data-sections.js	Adds nationality to the dependant summary.
apps/​saa/​index.js	Registers the page field in the journey.
apps/​saa/​fields/​index.js	Defines the required country select field.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

The autocomplete can submit a previously selected nationality after its visible value is edited on iOS.

0 open findings

Previously missed (2)

In code that hasn't changed since last review

Clear hidden value when input differs from selected option

assets/​js/​index.js:36

This checks the text against every option rather than the option currently selected in the hidden select. On iOS, Accessible Autocomplete disables autoselect; after editing a saved country to another valid country name without tapping a suggestion, blur does not confirm it, so the old hidden value is submitted while the new country remains visible. Clear whenever the input no longer matches the selected option.

Correct grammar in comment

assets/​js/​index.js:21

Correct the grammar in this comment.

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

The enhanced field loses required semantics, and stale nationality data can appear in the summary.

1 open finding

• Hide nationality when dependant answer changes to no · New

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

The enhanced required field loses its required accessibility state, and its synchronization logic lacks regression tests.

2 open findings

• Preserve aria-required on the enhanced combobox · New
• Add unit tests for nationality typeahead synchronization · New

1 resolved since last review

• Hide nationality when dependant answer changes to no

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

The displayed autocomplete value can diverge from the nationality submitted by the hidden select.

1 open finding

• Valid country text can differ from submitted selection · New

2 resolved since last review

• Preserve aria-required on the enhanced combobox
• Add unit tests for nationality typeahead synchronization

Previously missed (1)

In code that hasn't changed since last review

Correct grammar in comment

assets/​js/​typeahead.js:19

Correct the grammar in this comment.

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

The typeahead emits redundant change events after its select has already been cleared.

1 open finding

• Avoid repeated clear calls and change events after the first keystroke · New

1 resolved since last review

• Valid country text can differ from submitted selection

Previously missed (1)

In code that hasn't changed since last review

Clarify why the required state is copied to the visible input

assets/​js/​typeahead.js:19

There is no validate-autocomplete behaviour in this application, so this comment gives a misleading reason for copying the attribute. Describe the actual purpose of preserving the required state on the generated visible input.

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The page is fully configured and covered by focused client-side tests, with only a minor comment grammar issue.

0 open findings

1 resolved since last review

• Avoid repeated clear calls and change events after the first keystroke

Previously missed (1)

In code that hasn't changed since last review

Fix missing “is” in comment

assets/​js/​typeahead.js:19

This comment is missing “is”; change it to “This is needed…” for grammatical clarity.

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Typeahead initialization repeats enhancement for every matching select, and the new behavior lacks unit coverage.

2 open findings

• Avoid duplicate typeahead initialization for multiple selects · New
• Add tests for typeahead initialization and default selection · New

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

Typeahead initialization remains outside the agreed DOM-ready lifecycle.

1 open finding

• Add tests for typeahead initialization and default selection

1 resolved since last review

• Avoid duplicate typeahead initialization for multiple selects

Previously missed (1)

In code that hasn't changed since last review

Move initTypeahead into the DOM-ready handler

assets/​js/​index.js:6

initTypeahead() still runs outside the existing DOM-ready handler, so the lifecycle change noted in the prior review thread has not been applied. Move it into the handler with initFileUpload() so initialization consistently occurs only after the form controls are available.

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The page configuration, progressive enhancement, validation, translations, summary integration, and targeted tests are consistent and complete.

0 open findings

1 resolved since last review

• Add tests for typeahead initialization and default selection

🧠 Review effort: Balanced