Incongruous NBEAM (instead of NBEAMS)

[radonnachie]

As a part of enabling floating point data ingest, which is the output of a beamformer, I adjusted the FITS header from NBEAM to NBEAMS. I similarly adjusted the rawspec_raw_hdr_t field.

I found the lack of an 's' to be out of sorts with NANTS in particular. It seems that the fb_hdr_t structure agrees with me.

I just want to confirm whether or not this is accepted by the maintainers, and to make a note of it.

[radonnachie]

The change in field so far has affected hpguppi_daq:hpguppi_rawspec.c, and all authors of the NBEAMS key-value, obviously.

[david-macmahon]

In what commit was NBEAM introduced?

[radonnachie]

13b7f0b
4 years ago
And I think that it isn't used anywhere.

In particular, my PR #58 also replaces the value of nants with that of nbeams if nbeams > 0, as that's the use case if upchannelising beamformed data (AFAIK). So, the lack of that piece of logic indicated to me that nbeam was a vestige of some forward thinking, rather than an integral cog.

[radonnachie]

@david-macmahon I'd love to resolve this minor issue :)

[radonnachie]

#41