feat(todo): add realtime countdown and badge sync - #72
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
@codex plz review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a3d2e1604
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export const invalidateECampusTodosCache = () => { | ||
| cacheGeneration += 1; | ||
| cachedResults.clear(); | ||
| inFlightLoads.clear(); |
There was a problem hiding this comment.
Prevent invalidated auto-login requests from changing accounts
When the badge refresh is auto-logging in with stored account A while the user saves or logs into account B, this only removes the promise from the maps; the old loadECampusTodosUncached continues executing eCampusLoginAPI and may later clear B's newly stored credentials after A fails authentication or overwrite the shared eCampus cookie with A's session. The generation check occurs only after all of those side effects, so account changes need to abort or serialize the prior authentication attempt, or check the generation before mutating credentials/session state.
Useful? React with 👍 / 👎.
# Conflicts: # src/background/index.ts
변경 사항
HH:mm:ss실시간 카운트다운을 표시하고, 12시간 이하에서는 긴급 색상을 적용합니다.D-1형태로 표시됩니다.NaN:NaN:NaN으로 표시되지 않게 했습니다.main을 병합해 시간표/content script 및 최신 빌드 구성을 함께 반영했습니다.배경
Todo 타이머 기능은 설정 미리보기, 저장 실패 처리, 날짜 입력 검증이 빠져 있었고, popup badge와 Todo 탭이 eCampus 데이터를 중복 요청할 수 있었습니다. 외부 입력 경계와 요청 공유 지점을 정리하고, 계정 변경 및 일시적 eCampus 장애 시에도 화면과 badge가 일관되도록 보완했습니다.
Closes #43
검증
pnpm exec tsc -b --forcepnpm run lintpnpm run test:timetable(10 tests)pnpm run build:local23:59:xx카운트다운 확인D-1표시 확인aria-checked전환 확인수동 확인
dist/를 Chrome에 다시 로드해 실제 MV3chrome.storage, action badge, service worker 동작 확인