Repository navigation
Harden input validation, fix sysctl persist, deduplicate helpers - #31
Merged
Merged
Conversation
Security: remove DirectCommand injection risk, sysctl key validation, HTTP scheme downgrade check, kernelmodule error propagation, repository input validation, cron path traversal rejection. Correctness: sysctl read-modify-write persist, file absolute path in Apply, kernelmodule hyphen normalization, FileOpts State field for block absent, condition.Shell error propagation. Quality: deduplicate truncate to shell.Truncate, fix stale Meta docs, kernelmodule test coverage, snap test coverage, dnf repo test, MapFS IsDir fix, remove redundant hostname alreadySet. Closes #30
TsekNet
changed the title
Replace taskExists with getTaskInfo that reads the existing task's action Path via Definition.Actions.Item(1).Path. Check now reports drift when the configured command differs from the blueprint.
…eduler Switch cron_windows.go from manual oleutil.CallMethod/GetProperty calls to capnspacehook/taskmaster, matching the pattern used by google/glazier. Cleaner typed API, proper handle lifecycle, and readable task property access via t.Definition.Actions. Check now reads the existing task's action Path and compares against the desired command. checkState extracted for cross-platform testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address all 23 findings from holistic correctness + quality review.
Test plan
go build ./...passes (Linux, macOS, Windows)go test -race ./...passes (all 25 packages)go vet ./...cleanCloses #30