Repository navigation
Fix all review findings from v0.0.10-v0.0.12 - #25
Merged
Merged
Conversation
File extension: mode() mutual exclusion for Content+URL, case-insensitive checksum, applyBlock respects Mode, httpClient redirect restriction, exact block marker matching, remote + block mode test coverage. Exec: ShellParams empty-slice guard, resolveShell dedup (3 return vals). Kernelmodule: module name validation, errors.Is(fs.ErrNotExist), isModuleLoaded/isModuleBlacklisted error propagation. Cron: newline injection validation in Schedule/Command/User/Name. Windows COM: errors.As for OleError type safety. Hostname: shared alreadySet() guard across all platforms. Repository: gpgcheck=1 default for dnf/yum. Docs: design.md hardcoded list replaced with directory link, examples.md nested navigation added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address all 19 review findings, add examples.md navigation, hostname idempotency.
See issue description for the full findings table.
Commits
docs: Add navigation links to top of examples.mdfix: Address all review findings from issues 17, 19, 21Test plan
go build ./...passes (Linux, macOS, Windows)go test -race ./...passesgo vet ./...cleanCloses #24