Skip to content

Propagate native exe exit codes from PowerShell #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TsekNet merged 1 commit into from
Apr 12, 2026
Merged

Propagate native exe exit codes from PowerShell #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion extensions/exec/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ var defaultPSParams = []string{"-NoProfile", "-NonInteractive", "-ExecutionPolic
// corrupts stdout parsing for OnlyIfMatch and adds latency.
const psPrefix = "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue'; "

// psSuffix is appended to every PowerShell -Command invocation.
// Propagates $LASTEXITCODE from native executables (msiexec, reg.exe, etc.)
// to the process exit code. Without this, powershell.exe exits 0 even when
// the native exe fails. Only fires when $LASTEXITCODE is non-null (pure
// cmdlet commands never set it).
const psSuffix = "; if ($LASTEXITCODE) { exit $LASTEXITCODE }"

// Opts configures an Exec resource.
type Opts struct {
Command string
Expand Down Expand Up @@ -127,7 +134,7 @@ func (e *Exec) shellCmd(ctx context.Context, command string) *exec.Cmd {
args = append(args, "/C", command)
default:
// PowerShell variants: wrap with error/progress preferences
args = append(args, "-Command", psPrefix+command)
args = append(args, "-Command", psPrefix+command+psSuffix)
}

return exec.CommandContext(ctx, binary, args...)
Expand Down
Loading