Open
Conversation
Signed-off-by: Danil Klimuk <[email protected]>
m-iwanicki
requested changes
Apr 17, 2026
|
|
||
| To provide the QubesOS users not only the packages with TrenchBoot patches but | ||
| the pckages with both TrenchBoot and QubesOS patches a set of automatic rebase | ||
| worklfows has been implemented for the three of the components mentioned above: |
Contributor
There was a problem hiding this comment.
Suggested change
| worklfows has been implemented for the three of the components mentioned above: | |
| workflows has been implemented for the three of the components mentioned above: |
pre-commit failure
| > component. Hence, there is no need for a rebase CI/CDs for this component. | ||
|
|
||
| To provide the QubesOS users not only the packages with TrenchBoot patches but | ||
| the pckages with both TrenchBoot and QubesOS patches a set of automatic rebase |
Contributor
There was a problem hiding this comment.
Suggested change
| the pckages with both TrenchBoot and QubesOS patches a set of automatic rebase | |
| the packages with both TrenchBoot and QubesOS patches a set of automatic rebase |
Comment on lines
+96
to
+97
| pkg_wf --> gh_artifacts : uploads RPM artifacts | ||
| trigger_wf --> woodpecker_ci : HTTP trigger\n(woodpecker-trigger.sh) |
Contributor
There was a problem hiding this comment.
Suggested change
| pkg_wf --> gh_artifacts : uploads RPM artifacts | |
| trigger_wf --> woodpecker_ci : HTTP trigger\n(woodpecker-trigger.sh) | |
| pkg_wf ..> gh_artifacts : uploads RPM artifacts | |
| trigger_wf ..> woodpecker_ci : HTTP trigger\n(woodpecker-trigger.sh) |
I think this is more of an API call (like when fetching patches?)
| ' WOODPECKER PIPELINE → external | ||
| ' ───────────────────────────────────── | ||
| wp_s1 ..> gh_artifacts : downloads RPMs\n(GitHub API) | ||
| wp_s3 --> ftp_server : deploys signed RPMs\n+ updates repo metadata |
Contributor
There was a problem hiding this comment.
Suggested change
| wp_s3 --> ftp_server : deploys signed RPMs\n+ updates repo metadata | |
| wp_s3 ..> ftp_server : deploys signed RPMs\n+ updates repo metadata |
Comment on lines
+111
to
+112
| | A --> B | Sequential job dependency (needs:) | | ||
| | A ..> B | Cross-repo workflow call / API call | |
Contributor
There was a problem hiding this comment.
This doesn't render and --> looks more like rendered ..>. Maybe:
Suggested change
| | A --> B | Sequential job dependency (needs:) | | |
| | A ..> B | Cross-repo workflow call / API call | | |
| | A <b>⇾</b> B | Sequential job dependency (needs:) | | |
| | A ⇢ B | Cross-repo workflow call / API call | |
This does render correctly in PlantUML server.
| @@ -0,0 +1,108 @@ | |||
| @startuml | |||
Contributor
There was a problem hiding this comment.
Same issues as in grub diagram
| @@ -0,0 +1,119 @@ | |||
| @startuml Automatic rebase CI/CD Workflows for QubesOS packages - TrenchBoot/xen | |||
Contributor
There was a problem hiding this comment.
Same issues as in grub diagram
| 2. [TrenchBoot/xen](https://github.com/TrenchBoot/xen) | ||
| 3. [TrenchBoot/qubes-antievilmaid](https://github.com/TrenchBoot/qubes-antievilmaid) | ||
|
|
||
| ## TrenchBoot/grub |
Contributor
There was a problem hiding this comment.
I think it would be a good idea to add couple more simple diagrams e.g. with just rebase (how it's done, without details)
|
|
||
|  | ||
|
|
||
| ## TrenchBoot/xen |
Contributor
There was a problem hiding this comment.
Xen + Grub look near identical (maybe the only differences are details e.g. variables?). Maybe merge it somehow? Or create more high level diagram e.g. with just:
- apply upstream patches
- rebase
- build
- upload
- download
- sign
- publish
Comment on lines
+71
to
+72
|
|
||
| wp_s1 --> wp_s2 |
Contributor
There was a problem hiding this comment.
Suggested change
| wp_s1 --> wp_s2 | |
| wp_pipeline --> wp_s1 : needs | |
| wp_s1 --> wp_s2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information check the TrenchBoot/trenchboot-issues#83 .