Skip X509Certificate2 fallback for PE files in signature check - #17
Merged
Conversation
HasEmbeddedDigitalSignature fell back to X509Certificate2 whenever the PE certificate-table check found no signature, and that fallback false-positives on Electron/Chromium exe content - causing the client to silently skip signing them. Gate the fallback to non-PE containers only (msi/cab/msix/appx); PE files now rely solely on the certificate- table read, which is authoritative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HasEmbeddedDigitalSignature fell back to X509Certificate2 whenever the
PE certificate-table check found no signature, and that fallback
false-positives on Electron/Chromium exe content - causing the client
to silently skip signing them. Gate the fallback to non-PE containers
only (msi/cab/msix/appx); PE files now rely solely on the certificate-
table read, which is authoritative.