Fix client side signature verification on Linux - #15
Merged
Conversation
Detect embedded Authenticode signatures by reading the PE certificate table and decoding it with SignedCms instead of relying on the Windows-only X509Certificate2 path, which always reported files as unsigned on Linux. Non-PE containers (msi/cab/msix/appx) still fall back to X509Certificate2 on Windows. Add a Linux sign-and-verify stage to the Jenkins pipeline mirroring the Windows flow, re-packing the Service zips with the signed dlls.
JoshuaPeddle
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect embedded Authenticode signatures by reading the PE certificate table and decoding it with SignedCms instead of relying on the Windows-only X509Certificate2 path, which always reported files as unsigned on Linux. Non-PE containers (msi/cab/msix/appx) still fall back to X509Certificate2 on Windows.
Add a Linux sign-and-verify stage to the Jenkins pipeline mirroring the Windows flow, re-packing the Service zips with the signed dlls.