Skip to content

feat: #89: add dependency check workflow#90

Open
lasnown wants to merge 8 commits into
developfrom
feature/#89-add-dependency-check-workflow
Open

feat: #89: add dependency check workflow#90
lasnown wants to merge 8 commits into
developfrom
feature/#89-add-dependency-check-workflow

Conversation

@lasnown
Copy link
Copy Markdown
Contributor

@lasnown lasnown commented May 28, 2026

Closes #89

@lasnown lasnown changed the base branch from master to develop May 28, 2026 12:54
@lasnown lasnown changed the title feat: #89: add dependency check workflow [DRAFT] feat: #89: add dependency check workflow May 28, 2026
@lasnown lasnown changed the title [DRAFT] feat: #89: add dependency check workflow feat: #89: add dependency check workflow May 29, 2026
Comment thread .github/workflows/check-dependencies.yml
Comment thread .github/workflows/check-dependencies.yml Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change make a difference? If I'm not confused, the Python version for Ruff is specified in ruff.toml

Copy link
Copy Markdown
Contributor Author

@lasnown lasnown May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, you're right, forgot about that one, thanks for noticing. I'll look into how we can still run linting on multiple Python version in CI

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, turns out it's mostly impossible, but more importantly - useless (which makes sense), so reverting this change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, we should run linting/formatting on a newer Python version since we're developing on it.

lasnown and others added 2 commits May 29, 2026 17:12
Co-authored-by: Artem Sheptunov <106321977+aasheptunov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a dependency check workflow

2 participants