Implement locks#13
Open
pupnewfster wants to merge 14 commits into
Open
Conversation
Lanse505
reviewed
Sep 4, 2019
pupnewfster
commented
Sep 6, 2019
| } else if (object instanceof FluidState) { | ||
| return fromTags(((FluidState) object).getFluid().getTags()); | ||
| } | ||
| return null; |
Member
Author
There was a problem hiding this comment.
Add support for EntityType tags (the final type of built in tag in MC that this doesn't already support)
Contributor
There was a problem hiding this comment.
If you're gonna do things regarding tags, you should add a way for an addon to register a Function<T,Tags>
Member
Author
There was a problem hiding this comment.
By this do you mean that they would be registering a function such as Function<Item, Tag<Item>> or what do you have in mind by this.
Member
Author
There was a problem hiding this comment.
For now I left a TODO to go back at some point and look into letting mods register other types of Tags as the system probably needs some work once we come up with more potential use cases.
SkySom
requested changes
Sep 7, 2019
| } else if (object instanceof FluidState) { | ||
| return fromTags(((FluidState) object).getFluid().getTags()); | ||
| } | ||
| return null; |
Contributor
There was a problem hiding this comment.
If you're gonna do things regarding tags, you should add a way for an addon to register a Function<T,Tags>
pupnewfster
commented
Sep 7, 2019
| } else if (object instanceof FluidState) { | ||
| return fromTags(((FluidState) object).getFluid().getTags()); | ||
| } | ||
| return null; |
Member
Author
There was a problem hiding this comment.
By this do you mean that they would be registering a function such as Function<Item, Tag<Item>> or what do you have in mind by this.
…re code for arrays
pupnewfster
force-pushed
the
feature_locks
branch
from
7097401 to
d1f97f6
Compare
…can access it easier from another machine if I don't work on it more before then.
pupnewfster
added a commit
that referenced
this pull request
May 28, 2022
…has changed yet beyond fixing the compiler errors, a couple typos, moving the lock registry implementation details to not be part of the API and adjusting a couple things that check Items to check IItemProviders instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.