Improve linters for traits#424
Merged
prince-chrismc merged 16 commits intoMar 25, 2026
Merged
Conversation
now just assume the current directory is correct
sadly then is less reusable than i wanted
prince-chrismc
commented
Mar 18, 2026
| shell: bash | ||
| - id: stage | ||
| #continue-on-error: true | ||
| uses: Thalhammer/patch-generator-action@v3 |
Collaborator
Author
There was a problem hiding this comment.
@Thalhammer when you have a chance, I also made Thalhammer/patch-generator-action#1 to support making more than 1 patch at a time 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pt3 since the testing is now generic, only 1 linter for the defaults is now needed. This moves it to a single shell script that can be called .github/actions/generate-defaults-dot-h/configure-traits.sh with all the information. Previously this was nodeJS in an action which maybe it very difficult to run.