refactor: improve mocking tests in FileSystemTests#1456
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors FileSystemTests to more directly validate mocked IFile behavior, and updates test dependencies to support the new assertion/verification style.
Changes:
- Update
Mock_File_Succeedsto assertReadAllTextreturns a configured value and verify the call occurred. - Add
aweXpect.Mockolateto the shared test package references. - Bump
Mockolatepackage version and centrally define theaweXpect.Mockolateversion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/TestableIO.System.IO.Abstractions.Wrappers.Tests/FileSystemTests.cs | Strengthens the mock test by asserting return value and verifying invocation. |
| tests/Directory.Build.props | Adds aweXpect.Mockolate to the common test dependencies. |
| Directory.Packages.props | Updates central package versions for Mockolate and adds aweXpect.Mockolate. |
tests/TestableIO.System.IO.Abstractions.Wrappers.Tests/FileSystemTests.cs
Outdated
Show resolved
Hide resolved
|
|
This is addressed in release v22.1.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
FileSystemTeststo more directly validate mockedIFilebehavior, and updates test dependencies to support the new assertion/verification style.Changes:
Mock_File_Succeedsto assertReadAllTextreturns a configured value and verify the call occurred.aweXpect.Mockolateto the shared test package references.Mockolatepackage version and centrally define theaweXpect.Mockolateversion.