fix: update FileVersionInfos when calling CopyTo, MoveTo and Replace on a IFileInfo#1455
Merged
vbreuss merged 1 commit intoTestableIO:mainfrom Apr 9, 2026
Merged
Conversation
FrancescoLuzzi
force-pushed
the
fix/maintain_version_infos
branch
from
602af4b to
eda19eb
Compare
vbreuss
approved these changes
Apr 9, 2026
Member
There was a problem hiding this comment.
Thanks, @FrancescoLuzzi, Looks good to me. I don't think it is necessary to clone the FileVersionInfo.
|
This is addressed in release v22.1.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where copying, moving or replacing a file would lose all the
FileVersionInfoinformations when using aMockFileSystemChanges:
MockFileDataalso copy theFileVersionInfoOpen questions:
FileVersionInfobe cloned or is the current fix enough?