Skip to content

Fix Android remote desktop touch clicks #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZacharyZcR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Android remote desktop touch clicks #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions app/tabs/sessions/remote-desktop/RemoteDesktop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ export function RemoteDesktop({ host, isVisible, title }: RemoteDesktopProps) {
// ── Single touch state ───────────────────────────────────────────────
let tpX = 0, tpY = 0, tpTime = 0, tpMoved = false;
let tfTimer = null;
const TAP_MS = 350;
const TAP_MOVE_PX = 8;

const dist2 = (e) => {
const dx = e.touches[1].clientX - e.touches[0].clientX;
Expand Down Expand Up @@ -412,13 +414,15 @@ export function RemoteDesktop({ host, isVisible, title }: RemoteDesktopProps) {

if (e.touches.length !== 1) return;
const tx = e.touches[0].clientX, ty = e.touches[0].clientY;
if (Math.abs(tx - tpX) > 4 || Math.abs(ty - tpY) > 4) tpMoved = true;
const moved =
Math.abs(tx - tpX) > TAP_MOVE_PX ||
Math.abs(ty - tpY) > TAP_MOVE_PX;

if (currentMode === 'touch') {
// Single finger always drives the remote mouse (click+drag), even when zoomed.
// The coordinate mapping (toRemote) already accounts for pan+zoom.
sendMouseAt(tx, ty, false, false, false, false);
tpMoved = true;
if (moved) tpMoved = true;
} else {
// Trackpad: relative movement
const rdx = (tx - tpX) * SENS * (remoteW / vpW()) / zoom;
Expand All @@ -439,15 +443,15 @@ export function RemoteDesktop({ host, isVisible, title }: RemoteDesktopProps) {

if (currentMode === 'touch') {
// Tap (no movement, quick) = click
if (!tpMoved && dur < 250 && e.changedTouches.length === 1 && e.touches.length === 0) {
if (!tpMoved && dur < TAP_MS && e.changedTouches.length === 1 && e.touches.length === 0) {
const tx = e.changedTouches[0].clientX, ty = e.changedTouches[0].clientY;
sendMouseAt(tx, ty, true, false, false, false);
setTimeout(() => sendMouseAt(tx, ty, false, false, false, false), 60);
}
} else {
// Trackpad
if (e.touches.length === 0) {
if (!tpMoved && dur < 250 && e.changedTouches.length === 1) {
if (!tpMoved && dur < TAP_MS && e.changedTouches.length === 1) {
sendMouseCursor(true, false);
setTimeout(() => sendMouseCursor(false, false), 60);
}
Expand Down
Loading