failing BushAuthoritySystem / GenomeAuthoritySystem tests #118

Activity

1. keturn

   added

   Type: BugIssues reporting and PRs fixing problemsIssues reporting and PRs fixing problems

   Category: Test/QARequests, Issues and Changes targeting tests and quality assuranceRequests, Issues and Changes targeting tests and quality assurance

   on Aug 11, 2021
2. skaldarnar commented on Aug 13, 2021

   

   skaldarnar

   on Aug 13, 2021

   Last edited by skaldarnar

   Contributor

   More actions

   MovingBlocks/Terasology#4841 (review) fixes the NPE, at least.

   With those changes, I get different failures in the tests:

   

   This seems to be because producer.getParentPrefab().getName() throws an NPE.

   The respective entity exists and does look like this, but it has no parent prefab 🤔

   {
         "id": 31,
         "alwaysRelevant": false,
         "engine:RetainComponents": {
           "components": [
             null
           ]
         },
         "engine:Location": {
           "replicateChanges": true,
           "lastPosition": [
             0.0,
             0.0,
             0.0
           ],
           "isDirty": true,
           "lastRotation": [
             0.0,
             0.0,
             0.0,
             1.0
           ],
           "rotation": [
             0.0,
             0.0,
             0.0,
             1.0
           ],
           "scale": 1.0,
           "position": [
             0.0,
             1.0,
             0.0
           ]
         },
         "engine:Block": {
           "block": "SimpleFarming:MatureTestBush",
           "position": [
             0,
             1,
             0
           ]
         },
         "engine:Network": {
           "networkId": 9,
           "replicateMode": "RELEVANT"
         },
         "SimpleFarming:BushDefinition": {
           "currentStage": 2,
           "seedDropChances": [
             0,
             1,
             1,
             1
           ],
           "seed": "SimpleFarming:TestSeed",
           "sustainable": true,
           "growthStages": {
             "SimpleFarming:TestBush:engine:halfblock": {
               "minTime": 500,
               "maxTime": 500
             },
             "SimpleFarming:TestBush": {
               "minTime": 500,
               "maxTime": 500
             }
           },
           "produce": "SimpleFarming:TestProduce"
         }
       }
   

   Did we change anything to how parent prefabs are computed/stored in the (recent) past? The code in that system was like that from the beginning...
3. keturn commented on Aug 13, 2021

   

   keturn

   on Aug 13, 2021

   ContributorAuthor

   More actions

   The only recent activity in this module was #117, which looks vaguely similar when I squint but I don't think is the problem here.

   No clue about any changes with the engine for prefabs overall.