fix: 源头规避数据错误问题 --story=134904270#755
Merged
luofann merged 1 commit intoJun 5, 2026
Merged
Conversation
# Reviewed, transaction id: 81551
There was a problem hiding this comment.
Code Review Summary
✅ 整体评价:代码变更合理,无问题。
本 PR 是一个单行修复,在 onUpdateLocationInfo 方法中将 type 字段从内部表示 'tasknode' 转换为画布组件期望的 'task'。
审查要点:
- ✅ 修复逻辑与同文件 L1485 的
normalizedType转换模式一致 - ✅ 画布组件(
ProcessCanvas)的onUpdateNodeInfo期望接收'task'类型,此修复确保数据正确传递 - ✅ 变更范围最小化,仅修改必要的一行
- ✅ 无安全、性能或架构问题
- ✅ 无需同步文档更新
LGTM 👍
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #755 +/- ##
=========================================
Coverage ? 83.10%
=========================================
Files ? 307
Lines ? 18167
Branches ? 0
=========================================
Hits ? 15098
Misses ? 3069
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
luofann
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed, transaction id: 81551