Skip to content

fix: 源头规避数据错误问题 --story=134904270#755

Merged
luofann merged 1 commit into
TencentBlueKing:masterfrom
Mianhuatang8:master_origin_fix_activity_data_redundancy
Jun 5, 2026
Merged

fix: 源头规避数据错误问题 --story=134904270#755
luofann merged 1 commit into
TencentBlueKing:masterfrom
Mianhuatang8:master_origin_fix_activity_data_redundancy

Conversation

@Mianhuatang8

Copy link
Copy Markdown
Collaborator

Reviewed, transaction id: 81551

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

整体评价:代码变更合理,无问题。

本 PR 是一个单行修复,在 onUpdateLocationInfo 方法中将 type 字段从内部表示 'tasknode' 转换为画布组件期望的 'task'

审查要点:

  • ✅ 修复逻辑与同文件 L1485 的 normalizedType 转换模式一致
  • ✅ 画布组件(ProcessCanvas)的 onUpdateNodeInfo 期望接收 'task' 类型,此修复确保数据正确传递
  • ✅ 变更范围最小化,仅修改必要的一行
  • ✅ 无安全、性能或架构问题
  • ✅ 无需同步文档更新

LGTM 👍

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@eaae3d0). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #755   +/-   ##
=========================================
  Coverage          ?   83.10%           
=========================================
  Files             ?      307           
  Lines             ?    18167           
  Branches          ?        0           
=========================================
  Hits              ?    15098           
  Misses            ?     3069           
  Partials          ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luofann luofann merged commit da050c8 into TencentBlueKing:master Jun 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants