fix: 节点丢失outgoing和incoming导致流程保存失败 --story=134904270#753
Merged
luofann merged 2 commits intoJun 4, 2026
Merged
Conversation
# Reviewed, transaction id: 81469
| end: 'end', | ||
| }; | ||
| if (data.type === 'tasknode') { | ||
| data.type = 'task'; |
There was a problem hiding this comment.
data.type(data 来自 node 参数的解构),会改变源对象的值。如果画布组件在事件触发后仍依赖 node.data.type === 'tasknode' 做其他判断,可能产生副作用。建议改为局部变量:
const normalizedType = data.type === 'tasknode' ? 'task' : data.type;然后在后续 typeMap[normalizedType] 和 switch(normalizedType) 中使用,避免突变源数据。如果已确认上游不会再读取该字段则可忽略。
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #753 +/- ##
=========================================
Coverage ? 83.10%
=========================================
Files ? 307
Lines ? 18167
Branches ? 0
=========================================
Hits ? 15098
Misses ? 3069
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Reviewed, transaction id: 81471
luofann
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed, transaction id: 81469