Repository navigation
fix(mcp): reject chat streams without completion - #4843
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The legacy Python MCP server's
chatandagent_chattools return partial (or empty) answers as successful results when the SSE connection ends before the backend sends acompleteevent. Raise a request error on EOF before completion so callers can detect an incomplete answer. Existing server error and complete-event handling are preserved.Type of Change
Testing
python -m unittest test_chat_sse test_chat_async_preflight(31 tests passed, Python 3.13 / MCP 2.3.0). Regression cases failed on the unmodified code and cover both chat paths, empty streams, partial answers, and unterminated frames.git diff --check origin/main...HEADpassed.python -m unittest discover -p 'test_*.py'(62 tests): 3 errors intest_file_path_securityon Windows (temporary directory cleanup permissions and missing symlink privilege), andtest_mcp_transports.HttpStatelessSmokeTesttimed out waiting for the HTTP server. The targeted chat tests passed. Full repository checks were not run; this change is limited to the legacy Python MCP server.Checklist
git diff --check origin/main...HEADpasses