fix: crash when creating database on PostgreSQL (macOS 26)#724
Merged
fix: crash when creating database on PostgreSQL (macOS 26)#724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXC_BAD_ACCESScrash inswift_retainwhen clicking Create in the Create Database dialog on PostgreSQL connections running macOS 26 (Tahoe)Builtin.ImplicitActorinto async closure thunks, shifting String argument slots and corrupting them with the MainActor protocol witness table addressDatabaseSwitcherViewModeldirectly toCreateDatabaseSheetinstead of an asynconCreateclosure, eliminating the problematic thunk chain entirelyTest plan