[BUGFIX] Rebuild theme assets from their current sources - #1354
Merged
Conversation
The generated files in resources/public/ predate the sources they are built from: - theme.min.js was last built in #1353. #1345 then changed assets/js/code-inline.js and PhpTextRole so that signature, flags and summary travel as separate plain-text data-* attributes while data-details stays empty. The shipped bundle only reads dataset.details, so the info modal of the :php: text roles shows neither signature nor flags nor summary. - theme.css and the four fa-*.woff2 files are FontAwesome 7.2.0, while package-lock.json pins 7.3.1 since #1333. Icons added in 7.3.1 (fa-matrix, fa-nextcloud, fa-codeberg and others) resolve to nothing. Both also reach the CDN: deploy-azure-assets.yaml uploads resources/public/ verbatim on every tag. Rebuilt with `npm ci && npm run build` on Node 24.16.0 (.nvmrc). bootstrap.min.js stays byte-identical. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
linawolf
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated files in
packages/typo3-docs-theme/resources/public/are older than the sources they are built from. Rebuilding tag0.40.1withnpm ci && npm run buildon Node 24.16.0 (.nvmrc) produces a differenttheme.min.js, a differenttheme.cssand four different font files;bootstrap.min.jscomes out byte-identical.The info modal of the
:php:text roles is broken in 0.40.1theme.min.jswas last built in #1353. #1345 then changed bothassets/js/code-inline.jsandPhpTextRole.php: signature, flags and summary now travel as separate plain-textdata-*attributes, andCodeInlineNodereceives''as help text, sodata-detailsis empty.The bundle that ships in 0.40.1 predates that change and reads only
dataset.details:So the modal renders neither signature nor flags nor summary. Verified in the published image
ghcr.io/typo3-documentation/render-guides:0.40.1(sha256:afc0ec1775c6cac35bfb13b06e7436ee618cc9e54baba083327cad1c9fb2277a): zero occurrences ofdataset.signature.CSS and fonts are FontAwesome 7.2.0, the lock file says 7.3.1
package-lock.jsonpins FontAwesome 7.3.1 since #1333 (16 Jul). The committedtheme.cssand the fourfa-*.woff2files are 7.2.0 — the last CSS build (#1290, 26 Jul) ran against outdatednode_modules. Icons added in 7.3.1 (fa-matrix,fa-nextcloud,fa-codeberg,fa-lotusand others) resolve to nothing, and the animation timings differ. The theme's own SCSS is in sync: no commit touchesassets/sassafter #1290.Reach
deploy-azure-assets.yamlcopiesresources/public/verbatim to the Azure CDN on every tag, so the stale files are also served fromtheme/typo3-docs-theme/0.40.1/.What this PR does
Runs the documented build and commits its output. No source file is touched.
Nothing in CI catches this — no workflow runs
npm run build, andmain.yamlonly runsnpm test. A follow-up PR adds that guard.