Skip to content

Bridge hlsDateRange from PlayerConfiguration to Android THEOplayerConfig#837

Merged
tvanlaerhoven merged 3 commits into
developfrom
devin/1781091253-bridge-hls-daterange-android
Jun 18, 2026
Merged

Bridge hlsDateRange from PlayerConfiguration to Android THEOplayerConfig#837
tvanlaerhoven merged 3 commits into
developfrom
devin/1781091253-bridge-hls-daterange-android

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Bridges the hlsDateRange property from the TypeScript PlayerConfiguration to Android's THEOplayerConfig.Builder in PlayerConfigAdapter.

This property was already bridged on iOS (via THEOplayerRCTView.swift) and at the source level on Android (via SourceAdapter.kt), but was missing at the player config level on Android.

The implementation follows the same pattern as tunnelingEnabled and useSystemCaptionStyle:

if (hasKey(PROP_HLS_DATERANGE)) {
  hlsDateRange(getBoolean(PROP_HLS_DATERANGE))
}

THEOplayerConfig.Builder().hlsDateRange() will be available in a future Android SDK release — this prepares the bridge code ahead of time.

Caution

Do not merge this PR until THEOplayer 11.5.0 is released. The hlsDateRange() method on THEOplayerConfig.Builder does not exist in the current SDK and will only become available in that release.

Link to Devin session: https://dolby.devinenterprise.com/sessions/c7dcfebf4c8e451aabcdc6d504fed72d


Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@tvanlaerhoven tvanlaerhoven self-requested a review June 10, 2026 11:36

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing copy-paste bug in imaSdkSettings: sessionId reads PPID value

At android/src/main/java/com/theoplayer/PlayerConfigAdapter.kt:162, the code checks hasKey(PROP_SESSION_ID) but then reads getString(PROP_PPID) instead of getString(PROP_SESSION_ID). This means setSessionId will always receive the PPID value rather than the actual session ID. This is a pre-existing bug unrelated to this PR's hlsDateRange change, but worth noting for a future fix.

(Refers to line 162)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot force-pushed the devin/1781091253-bridge-hls-daterange-android branch from 66fcf32 to 1761524 Compare June 10, 2026 13:42
devin-ai-integration Bot and others added 3 commits June 18, 2026 17:54
Add hlsDateRange property bridging in PlayerConfigAdapter, consistent with
how tunnelingEnabled and useSystemCaptionStyle are already bridged.
THEOplayerConfig.Builder().hlsDateRange() will be available in a future SDK
release.

Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
@tvanlaerhoven tvanlaerhoven force-pushed the devin/1781091253-bridge-hls-daterange-android branch from 1761524 to fe36ffb Compare June 18, 2026 15:54
@tvanlaerhoven tvanlaerhoven merged commit c091c97 into develop Jun 18, 2026
3 of 4 checks passed
@tvanlaerhoven tvanlaerhoven deleted the devin/1781091253-bridge-hls-daterange-android branch June 18, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant