Bridge hlsDateRange from PlayerConfiguration to Android THEOplayerConfig#837
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
🚩 Pre-existing copy-paste bug in imaSdkSettings: sessionId reads PPID value
At android/src/main/java/com/theoplayer/PlayerConfigAdapter.kt:162, the code checks hasKey(PROP_SESSION_ID) but then reads getString(PROP_PPID) instead of getString(PROP_SESSION_ID). This means setSessionId will always receive the PPID value rather than the actual session ID. This is a pre-existing bug unrelated to this PR's hlsDateRange change, but worth noting for a future fix.
(Refers to line 162)
Was this helpful? React with 👍 or 👎 to provide feedback.
66fcf32 to
1761524
Compare
Add hlsDateRange property bridging in PlayerConfigAdapter, consistent with how tunnelingEnabled and useSystemCaptionStyle are already bridged. THEOplayerConfig.Builder().hlsDateRange() will be available in a future SDK release. Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
…d of PROP_SESSION_ID" This reverts commit e8dca0e.
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
1761524 to
fe36ffb
Compare
Summary
Bridges the
hlsDateRangeproperty from the TypeScriptPlayerConfigurationto Android'sTHEOplayerConfig.BuilderinPlayerConfigAdapter.This property was already bridged on iOS (via
THEOplayerRCTView.swift) and at the source level on Android (viaSourceAdapter.kt), but was missing at the player config level on Android.The implementation follows the same pattern as
tunnelingEnabledanduseSystemCaptionStyle:THEOplayerConfig.Builder().hlsDateRange()will be available in a future Android SDK release — this prepares the bridge code ahead of time.Caution
Do not merge this PR until THEOplayer 11.5.0 is released. The
hlsDateRange()method onTHEOplayerConfig.Builderdoes not exist in the current SDK and will only become available in that release.Link to Devin session: https://dolby.devinenterprise.com/sessions/c7dcfebf4c8e451aabcdc6d504fed72d