Move project storage code from data_connectors to storage module - #1397
Merged
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1397.dev.renku.ch |
eikek
force-pushed
the
eikek/move-to-storage-module
branch
from
July 31, 2026 08:52
1cadb87 to
1755f91
Compare
eikek
force-pushed
the
eikek/move-to-storage-module
branch
from
July 31, 2026 11:21
3f1c1c8 to
00a37a7
Compare
Coverage Report for CI Build 32226286864Warning No base build found for commit Coverage: 85.95%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
eikek
marked this pull request as ready for review
July 31, 2026 12:36
olevski
requested changes
Aug 18, 2026
olevski
left a comment
olevski
left a comment
Member
There was a problem hiding this comment.
One small thing Eike. You just forgot to update the paths in the apispec yaml file.
olevski
self-requested a review
August 18, 2026 16:57
olevski
approved these changes
Aug 18, 2026
- adopt test to new (pydantic) validation error
they worked before because of being merged in from data_connectors
Contributor
|
Tearing down the temporary RenkuLab deployment for this PR. |
eikek
added a commit
that referenced
this pull request
Aug 19, 2026
* WIP: starting move * Moved more code * Change path to /storage * Fix alembic migration sequence * register storage orms * Fix type error * Change api tags to storage * Fix path in api.spec.yaml * Fix validation errors * Add `additionalProperties: false` to explicitly disallow extra param * Fix query to select projects * style fix * Remove left-over defs in data_connector api.spec - adopt test to new (pydantic) validation error * Fix exclusiveMinimum spec * Add missing types in api spec they worked before because of being merged in from data_connectors
eikek
added a commit
that referenced
this pull request
Aug 21, 2026
* WIP: starting move * Moved more code * Change path to /storage * Fix alembic migration sequence * register storage orms * Fix type error * Change api tags to storage * Fix path in api.spec.yaml * Fix validation errors * Add `additionalProperties: false` to explicitly disallow extra param * Fix query to select projects * style fix * Remove left-over defs in data_connector api.spec - adopt test to new (pydantic) validation error * Fix exclusiveMinimum spec * Add missing types in api spec they worked before because of being merged in from data_connectors
olevski
pushed a commit
that referenced
this pull request
Aug 24, 2026
* WIP: starting move * Moved more code * Change path to /storage * Fix alembic migration sequence * register storage orms * Fix type error * Change api tags to storage * Fix path in api.spec.yaml * Fix validation errors * Add `additionalProperties: false` to explicitly disallow extra param * Fix query to select projects * style fix * Remove left-over defs in data_connector api.spec - adopt test to new (pydantic) validation error * Fix exclusiveMinimum spec * Add missing types in api spec they worked before because of being merged in from data_connectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the project storage code from the
data_connectorsmodule into thestoragemodule./deploy