Skip to content

🎨 Palette: Accessible Interaction Polish#36

Merged
Sumit-5002 merged 1 commit into
mainfrom
palette/accessible-interaction-polish-8822987178-18325192815607195447
Apr 1, 2026
Merged

🎨 Palette: Accessible Interaction Polish#36
Sumit-5002 merged 1 commit into
mainfrom
palette/accessible-interaction-polish-8822987178-18325192815607195447

Conversation

@Sumit-5002

@Sumit-5002 Sumit-5002 commented Mar 27, 2026

Copy link
Copy Markdown
Owner

🎨 What: The UX enhancement added

This PR introduces a series of micro-accessibility improvements to the authentication and file processing workspace.

🎯 Why: The user problem it solves

  1. Form Clarity: The AuthPage used placeholder text instead of visible labels, which is an accessibility anti-pattern. Adding aria-label ensures screen readers can identify the inputs correctly.
  2. Toggle Feedback: The password visibility toggle had no way of communicating its current state to non-visual users.
  3. Keyboard Discoverability: In the ToolWorkspace, action buttons (like View and Download) were hidden inside an overlay that only appeared on hover. This made them completely inaccessible to keyboard users.

♿ Accessibility: Any a11y improvements made

  • ARIA Labels: Added to all icon-only buttons and label-less inputs.
  • Dynamic State: The password toggle now updates its aria-label from "Show password" to "Hide password" on click.
  • Focus Management: Used :focus-within to reveal hidden overlays when a child element receives keyboard focus.

All changes are strictly UX/a11y focused and stay within the 50-line limit per file.


PR created automatically by Jules for task 18325192815607195447 started by @Sumit-5002

Summary by CodeRabbit

  • Accessibility Improvements
    • Added screen reader support to sign-up and login form inputs and controls.
    • Enhanced keyboard navigation for artifact preview overlays.
    • Improved accessibility labels on preview action buttons for assistive technology users.

- Added `aria-label` to all form inputs and the role selection dropdown in `AuthPage.jsx` to improve screen-reader accessibility for users.
- Implemented a dynamic `aria-label` for the password visibility toggle in `AuthPage.jsx`.
- Added `aria-label` to "View" and "Download" icon-only buttons in `ToolWorkspace.jsx` (ResultItem).
- Updated `ToolWorkspace.css` to show the `artifact-overlay` on `:focus-within`, ensuring action buttons are visible and reachable for keyboard-only users.
- Verified changes via automated Playwright UI tests and visual inspection.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1537c845-61ea-4ba4-a5e6-752eb7ee9bc5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)

✅ Unit Test PR creation complete.

  • Create PR with unit tests
  • Commit unit tests in branch palette/accessible-interaction-polish-8822987178-18325192815607195447

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sumit-5002
Sumit-5002 marked this pull request as ready for review March 27, 2026 07:54
@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.


Generating unit tests... This may take up to 20 minutes.

1 similar comment
@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.


Generating unit tests... This may take up to 20 minutes.

@Sumit-5002

Sumit-5002 commented Mar 27, 2026

Copy link
Copy Markdown
Owner Author

@jules just i check the ui..see forgot passward ...in logn it is not working correct..see add that. The link for forgot passward via email or Google what ever is connected to firebase..all that logn system right..i check GitHub and few other are still not connected..so check once it should show upcoming feature or something like that..

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Request timed out after 900000ms (requestId=26c53d7b-baf7-487e-8fe8-57c6fc31dda0)

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Request timed out after 900000ms (requestId=01360a18-04ba-4af4-b804-f48d8dc27413)

@Sumit-5002
Sumit-5002 marked this pull request as draft March 27, 2026 12:16
@Sumit-5002
Sumit-5002 marked this pull request as ready for review April 1, 2026 16:07
@Sumit-5002
Sumit-5002 merged commit 39ae4e8 into main Apr 1, 2026
2 checks passed
@Sumit-5002
Sumit-5002 deleted the palette/accessible-interaction-polish-8822987178-18325192815607195447 branch April 1, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant