Add protocolTimeout support to puppeteer launch options#307
Open
zenom wants to merge 1 commit into
Open
Conversation
Batch print jobs with large case counts can exceed Puppeteer's default 180 second CDP protocol timeout, resulting in ProtocolError: Network.enable timed out. Puppeteer exposes protocolTimeout in its launch options to raise this limit, but Grover never extracted it into launchParams — the value would silently pass through to page.pdf() where it has no effect. This change extracts it so callers can configure the CDP timeout when longer-running operations require it. Also adds protocol_timeout to the integer coercion list in OptionsFixer so it works consistently when set via HTML meta tags, which always produce string values. See: Studiosity#248
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Batch print jobs with large case counts can exceed Puppeteer's default 180 second CDP protocol timeout, resulting in:
This was reported in #248.
Root cause
Puppeteer exposes
protocolTimeoutin its launch options to raise this limit, but Grover never extracted it intolaunchParams— the value would silently pass through topage.pdf()where Puppeteer ignores it entirely.Fix
Extract
protocolTimeoutfrom the options hash and pass it intolaunchParamsbefore callingpuppeteer.launch(), consistent with howlaunchTimeout,executablePath, and other launch options are handled.Also adds
protocol_timeoutto the integer coercion list inOptionsFixerso it behaves consistently when set via HTML meta tags, which always produce string values.Usage
Or globally: