Make installer truly cross-platform and CPU-arch aware#4
Open
999sian wants to merge 1 commit into
Open
Conversation
999sian
commented
Jul 9, 2026
999sian
commented
The launcher advertises Windows/macOS/Linux support but several paths were Windows-only or ignored the host CPU architecture, so a non-x86_64 or non-Windows user could get the wrong asset or a crash. github_api: _parse_release grouped assets per OS family and picked the asset matching the host arch (platform.machine, normalized) instead of letting the last asset in the list win; it now also parses macOS assets. Single-arch releases still install via arch fallback. Added select_asset()/platform_key() helpers that resolve the correct asset for the running host from a release dict or sqlite3.Row. database: added macos_* columns with an additive, idempotent migration (ALTER TABLE ... ADD COLUMN guarded by OperationalError, since SQLite has no ADD COLUMN IF NOT EXISTS) so existing DBs upgrade in place. launcher: resolve tmc_pc.exe on Windows and bare tmc_pc elsewhere, and restore the exec bit before launch (POSIX). installer: restore the exec bit on tmc_pc/asset_extractor after extraction, which uses set_attrs=False and would otherwise strip it. ui: home/releases tabs install the host-appropriate asset via select_asset; releases card shows macOS size; settings "Open Folder" uses open/xdg-open instead of the Windows-only os.startfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.