Repository navigation
Conversation
…ocus The battery window opens by itself every time the case lid is seen opening. Users asked for a way to turn that off (SpriteOvO#233) and for it not to steal focus from the app in use, which minimizes full-screen games (SpriteOvO#203). - New setting `popup_on_lid_open` (on by default, so nothing changes for existing users), with a card on the Features page. When off, the window only opens from the tray icon or the taskbar status. - When the popup opens because of the lid, it is shown with Qt::WA_ShowWithoutActivating. Opening it from the tray still activates it as before. Closes SpriteOvO#203 Refs SpriteOvO#233 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Amazing work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203. Refs #233.
Problem
The battery window opens by itself whenever the case lid is seen opening, and it gets activated when it does. Two requests came out of that:
@WolfCTOS mentioned in #233 that they planned to add a setting for this. I asked there on 23 Sep whether they were still on it and offered to take it, and there has been no reply since, so here it is. Happy to close this if a different approach is already in the works.
Changes
popup_on_lid_open. It is on by default, so nothing changes for existing users. It gets a card on the Features page, next to automatic ear detection. When it is off, the window only opens from the tray icon or the taskbar status.Qt::WA_ShowWithoutActivating(newMainWindow::ShowWithoutActivating). Opening it from the tray or the taskbar still activates it as before. The lid-only signalShowSafelyis renamed toShowWithoutActivatingSafelyto make that explicit.UiRenderingTestschecks the new checkbox along with the other setting checkboxes (accessible name, minimum size).The new strings are not in the
.tscatalogs yet. I left them for the usuallupdatepass so this doesn't conflict with the open translation PRs.Testing
Windows 11, AirPods Pro, release build, with the fix from #246 also applied locally:
GetForegroundWindow).popup_on_lid_opencheck inApplication.cpp, and the checkbox is wired the same way as the other setting checkboxes.🤖 Generated with Claude Code