Skip to content

Add shift_times to BaseSorting#4551

Open
h-mayorquin wants to merge 3 commits intoSpikeInterface:mainfrom
h-mayorquin:add_shift_times_to_sorting
Open

Add shift_times to BaseSorting#4551
h-mayorquin wants to merge 3 commits intoSpikeInterface:mainfrom
h-mayorquin:add_shift_times_to_sorting

Conversation

@h-mayorquin
Copy link
Copy Markdown
Collaborator

BaseRecording has shift_times (#3509). BaseSorting got get_start_time/get_end_time in #4525 but no way to shift the timing through the public API. This PR adds shift_times to BaseSorting.

shift_times on a sorting never mutates the registered recording. After #4525, register_recording copies the recording's start time into each segment's _t_start, so _t_start represents the effective start time of the segment. shift_times(delta) adds delta to _t_start. When a recording is registered, the effective shift relative to the recording is _t_start - recording.get_start_time(); this is 0 right after registration and becomes 5.0 after shift_times(5.0).

sample_index_to_time, time_to_sample_index, get_end_time, and get_times now compose this shift. I also updated the get_unit_spike_train_in_seconds native path (used by NWB extractors) which previously ignored _t_start.

@h-mayorquin h-mayorquin marked this pull request as ready for review April 22, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant