chore: automatically bundle latest collector versions in docker image BED-7545#194
chore: automatically bundle latest collector versions in docker image BED-7545#194lrfalslev wants to merge 9 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe publish workflow now computes SHA-256 checksums from inside the ChangesPublish Workflow Enhancements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish.yml:
- Around line 158-162: Move the "Upload Latest Version to S3" step out of the
matrix legs and into a new job named publish_latest_version_marker that has
needs: sign so it only runs after all sign matrix jobs succeed; in that job run
the same upload command (echo -n "${{ env.AZUREHOUND_VERSION }}" | aws s3 cp -
s3://${{ secrets.BHE_AWS_BUCKET }}/azurehound-latest-version) and keep the same
conditional check (if: ${{ !contains(env.AZUREHOUND_VERSION, '-') }}), set
runs-on (e.g., ubuntu-latest) and any required aws credentials/permissions, and
remove the original step from the matrix job so the marker is uploaded exactly
once after all signing legs finish successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ad79776e-95b5-4f69-97c4-c8a8ebd6cd2b
📒 Files selected for processing (1)
.github/workflows/publish.yml
Description
Update azurehound-latest-version marker file in s3 after new non-rc releases
Motivation and Context
This PR addresses: BED-7545
How Has This Been Tested?
Workflow ran and azurehound-latest-version contents validated.
Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit