Allow Ruby 4.0.0; add test suite, CI, and CHANGELOG#1
Merged
Conversation
- Relaxed `required_ruby_version` to `>= 2.5.0, < 5.0` - Bumped `faraday-follow_redirects` upper bound to allow 0.5+ (which lifts the Ruby < 4 cap) - Added test/ suite (test-unit + VCR + webmock) in the style of colrapi, covering version, ontologies, and search - Added Rake::TestTask and test default task - Added GitHub Actions workflow with a Ruby 3.3.4 / 4.0.0 matrix - Added CHANGELOG.md - Bumped version to 0.1.1 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
CI re-records on every run against the live OLS API. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Needed in order for ./bin/console to work
Correct me if wrong, but I think usually Gemfile.lock is not included in gems because it makes it harder for gem users to manage dependencies.
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| ruby-version: ['3.3.4', '4.0.0'] |
There was a problem hiding this comment.
Probably should be ['3.3', '3.4', '4.0'] so it used latest patch version of each minor?
Collaborator
|
Thanks @gdower, merging this and then I'll make @LocoDelAssembly's suggested change and release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required_ruby_versionto>= 2.5.0, < 5.0faraday-follow_redirectsupper bound to allow 0.5+ (which lifts the Ruby < 4 cap)