feat(maker-appimage): Refactor workDir over using keyword - #28
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 88.11% 88.41% +0.29%
==========================================
Files 5 5
Lines 1052 1079 +27
Branches 135 139 +4
==========================================
+ Hits 927 954 +27
Misses 125 125 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This currently relies on TypeScript JS glue to offer this feature in older Node engines that had support for neccesary globals and JS definitions but had no syntax support in V8. This would be breaking as it bumps required Node.js release… if not for the fact that Node<=22 was documented as dropped in release notes, even if `package.json` did not reflect this at module level.
SpacingBat3
force-pushed
the
feat/using-keyword
branch
from
August 18, 2026 18:41
6d8ec5a to
6ba413b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is implementation of disposable resources management that are stored in filesystem, based on
usingdeclaration and temporarily introduced new type, that will be replaced by Node.jsmkdtempDisposable()API once it will be stabilized over multiple Node versions.