Skip to content

Implemented Cosine and Jaccard Similarity classes - #6

Open
muratcancicek wants to merge 9 commits into
bootstrapfrom
matrix_operations
Open

muratcancicek wants to merge 9 commits into
bootstrapfrom
matrix_operations

Conversation

@muratcancicek

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Apr 26, 2024

Copy link
Copy Markdown

size-limit report 📦

Path Size
dist/crunchdb.cjs.production.min.js 3.55 KB (+5.16% 🔺)
dist/crunchdb.esm.js 2.9 KB (+6.23% 🔺)

@sdmuki sdmuki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look great. I will change the interfaces to return ResultAsync types instead. You can change the implementations after that

Comment thread src/implementations/ranking/CosineSimilarity.ts Outdated
Comment thread src/interfaces/ranking/ISimilarityMeasure.ts Outdated
@muratcancicek muratcancicek added the bug Something isn't working label Apr 30, 2024
@muratcancicek muratcancicek removed the bug Something isn't working label Apr 30, 2024
Comment thread src/implementations/ranking/SampleSimilarity.ts Outdated
@muratcancicek
muratcancicek requested a review from sdmuki May 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants