Skip to content

Added power Orb and Lantern Deploy Range indicators - #2613

Open
Toosiii wants to merge 2 commits into
SkyblockerMod:mainfrom
Toosiii:power-Orb-Lantern-Range
Open

Added power Orb and Lantern Deploy Range indicators#2613
Toosiii wants to merge 2 commits into
SkyblockerMod:mainfrom
Toosiii:power-Orb-Lantern-Range

Conversation

@Toosiii

@Toosiii Toosiii commented Jul 31, 2026

Copy link
Copy Markdown
Base Profile Screenshot 2026 07 31 - 15 30 12 28 Base Profile Screenshot 2026 07 31 - 15 29 57 98 Base Profile Screenshot 2026 07 31 - 15 30 37 62 Base Profile Screenshot 2026 07 31 - 15 30 18 56

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 31, 2026

@kevinthegreat1 kevinthegreat1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't create a new category for one config. It can go into helpers. Also the feature class should go in the helpers package. Also please don't create separate files for each config class. Please make sure the order in the config category matches the order of fields in the config.

You have a lot of duplicate code, you can clean that up a lot. Also, how does this handle deployables from other players? Please also remove the lots of extra empty lines.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this class doing here?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a better place to put this instead of a new module.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is if we want to see others or not?
As on now you the lates one placed will be shown

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jul 31, 2026
@AzureAaron AzureAaron added this to the 6.10.0 milestone Aug 1, 2026
…eprCategory - Removed PowerOrbConfig.java (and the package-infos)- Removed RangeCircleRenderer.java - Moved Lantern Config into the existing structure - LanternDeployable Detects deployables from other players - Cleand Up
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Aug 1, 2026
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Aug 20, 2026
@AzureAaron AzureAaron modified the milestones: 6.10.0, 6.11.0 Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature This issue or PR is a new feature reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants