Add important performance mods - #34
Conversation
AzureAaron
left a comment
There was a problem hiding this comment.
My thoughts:
ModernFix: No, it has a feature for disabling chat signing that breaks the mod's API usage and I don't agree with putting this mod in front of users by default where they could unknowingly select this and break their profile viewer, score calculation etc. Last I checked it also blocks all telemetry by default which is bad because it's used to improve the game (e.g. reporting to Mojang what graphics the device supports).
Dynamic FPS: I don't know about that one either, Vanilla already has a FPS limit feature which is fine for most use cases. The modpack is meant to be light and I don't see much value in adding a mod whose primary purpose was eclipsed by Mojang long ago.
Particle Core: I don't have much of an opinion, it should be checked to make sure it works with all of Aaron Mod's particle features as those shouldn't become broken by including this.
Legacy Textures: I don't think this should be promoted either (especially not as recommended), we've made various changes across the mod (compatibility and design wise) to adapt to the sb resource pack and reverting the pack runs counterintuitive to that. That section was meant for promoting partnered packs anyways which the legacy pack doesn't apply to as we are not partners.
|
Particle Core in particular should be compatible with just about any mod (otherwise I'd have suggested Async Particles). It also feels important given the lag particles cause in vanilla and how heavily skyblock makes use of them. |
|
If it turns out the mod list is fully compatible there are two mods that are better performance (at the cost of stability):
|
|
iirc Gnetum has some issues with some other popular SkyBlock mods, so it would be best not to add it for now. |
AzureAaron
left a comment
There was a problem hiding this comment.
Apparently better block entities crashes with skyblocker so it shouldn’t be added.
That's weird, I've been using better block entities with skyblocker for more than one or two months and never ran into that. Is there a github issue or something with crash logs? |
|
I sourced performance mods from the Adrenaline modpack because it prioritizes stability and real measurable performance gains. They have an active community on both Discord and Github and are highly receptive to feedback. Ideally the Skyblocker modpack would extend from Adrenaline directly but I wasn't able to figure out a way to do that (packwiz limitation?). So instead I just added the mods currently in Adrenaline that the Skyblocker modpack was missing.
I also added Hypixel Skyblock Legacy to the list of recommended resource packs because it fits well there.