Skip to content

[3.0][Testing] Anchor the canonical path test to the root the platform actually uses #9600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdarwood007 merged 1 commit into from
Aug 31, 2026
Merged

[3.0][Testing] Anchor the canonical path test to the root the platform actually uses #9600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/Unit/SapiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,14 @@ class SapiTest extends TestCase

public function testCanonicalPathResolvesDotSegments(): void
{
$this->assertSame('/a/c', Sapi::canonicalPath('/a/./b/../c', false, false));
$this->assertSame('/a', Sapi::canonicalPath('/a/b/..', false, false));
// The root of an absolute path is a drive letter on Windows and nothing
// at all on POSIX, so name it here rather than let the current drive
// decide. Everything after it is the same on both.
$root = DIRECTORY_SEPARATOR === '/' ? '' : 'C:';
$sep = DIRECTORY_SEPARATOR;

$this->assertSame($root . $sep . 'a' . $sep . 'c', Sapi::canonicalPath($root . '/a/./b/../c', false, false));
$this->assertSame($root . $sep . 'a', Sapi::canonicalPath($root . '/a/b/..', false, false));
}

public function testTheSuiteRunsOnTheCommandLine(): void
Expand Down
Loading